Handle Task/GenServer exits correctly in Google formatter

Nebo15 / logger_json

JSON logger formatter with support for Google Cloud, DataDog and other for Elixir.

https://nebo15.github.io/logger_json/

MIT License

237 stars 92 forks source link

Handle Task/GenServer exits correctly in Google formatter #133

Closed BrentWheeldon closed 4 weeks ago

BrentWheeldon commented 1 month ago

We were running into a situation where errors caused by GenServers terminating were not being formatted because they were a slightly different shape to what was expected in the formatter. This updates the formatter to handle them.

I'm very open to implementing and/or testing this in a different way - any/all feedback appreciated!

coveralls commented 4 weeks ago

coverage: 100.0%. remained the same when pulling 25d719c3d0c836e755c6ba28f14846979c70f196 on mechanical-orchard:log-exits into 5ad0deed1be98e04a00ae1357f1314ca990ffebf on Nebo15:master.

dankentfield commented 2 weeks ago

Thank you ❤️. I will make sure it's ported to other formaters too

@AndrewDryga do you know if this has been ported to the datadog formatter yet?

I think (but am not sure) this might be happening there too.