Basic formatter discarding file, line and mfa

Nebo15 / logger_json

JSON logger formatter with support for Google Cloud, DataDog and other for Elixir.

https://nebo15.github.io/logger_json/

MIT License

237 stars 92 forks source link

Basic formatter discarding file, line and mfa #137

Open ppeerttu opened 1 week ago

ppeerttu commented 1 week ago

Hi! Thanks for a great library. Just wondering why does the LoggerJSON.Formatters.Basic discard the file, line and mfa information? To me it looks like it's impossible to configure the basic formatter to include them, and that's what I specifically would like to do.

AndrewDryga commented 3 days ago

Hi @ppeerttu. This is by mistake, a PR would be welcome. I believe all you have to do is to remove those three here and make a test that makes sure we don't have a regression: https://github.com/Nebo15/logger_json/blob/master/lib/logger_json/formatters/basic.ex#L22

ppeerttu commented 1 day ago

@AndrewDryga awesome, I'll make a PR as soon as I can, perhaps already this week.