[enhancement] Support for providing a extra_attributes_fn to LoggerJSON Plug

Nebo15 / logger_json

JSON logger formatter with support for Google Cloud, DataDog and other for Elixir.

https://nebo15.github.io/logger_json/

MIT License

237 stars 92 forks source link

[enhancement] Support for providing a extra_attributes_fn to LoggerJSON Plug #50

Closed themitigater closed 4 years ago

themitigater commented 4 years ago

Support adding metadata to LoggerJSON Plug logs. A very good example of this is logging added by gatewaysx-request-id

coveralls commented 4 years ago

Coverage increased (+0.9%) to 75.0% when pulling ba0c7c3ecbbd0941a8b3bc9da34471b2f9aa904b on themitigater:extra_attribute_fn into 1eb578a4c3286857f65f855fe2df69d13ee4f125 on Nebo15:master.

themitigater commented 4 years ago

Hey, @AndrewDryga I need this for an internal app, when will you able to make this available? In case you're going to take time to review I can resort to using the fork.

AndrewDryga commented 4 years ago

I'm closing this for now, we can reopen if we find that the discussed solution does not work in some use cases.