Closed btkostner closed 3 years ago
Hey @btkostner, sorry for taking so long to reply. This generally looks good to me but needs to clean up some docs from GKE. I notice there is a duplication issue arising and I had ideas how we can restructure this package into something behavior-based to avoid it, but that can be done later, I don't want to overwhelm you.
Did you have a chance to try this formatter in production?
I tried this formatter a bit while I was developing it, but I haven't put it in a production environment yet. I can pull a screenshot of it in Datadog after the PR fixes are done if you want.
@btkostner Would it be used in production? I want to make sure it would have some real usage if we add it, because we will need to maintain it. Otherwise, we can add a notice to the docs that this formatted is experimental and I'll remove that notice once we have somebody who run it for some time in the real app.
Yes. This will be used for System76 elixir projects in production. Along that line, what are your thoughts about other json formatters similar to the ecto one?
@btkostner from your examples they look good to me, if we need we can tune them later but until more people start to use this formatter :).
This adds a
DatadogLogger
and aPlug
DatadogLogger
. Copied mostly from the Google version. Field names are from the Datadog docs and should work out of the box for most people.Let me know if there are things I missed, or anything you want changed.
Outputs: