search

Nebo15 / logger_json

JSON logger formatter with support for Google Cloud, DataDog and other for Elixir.
https://nebo15.github.io/logger_json/
MIT License
237 stars 92 forks source link

Change System.get_pid/0 to System.pid/0 #81

Closed wingyplus closed 2 years ago

wingyplus commented 2 years ago

System.get_pid/0 is deprecated in flavor of System.pid/0. Since we use this function, we need to bump minimum elixir requirement to be at least version 1.9.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 74.79% when pulling 0afe403f3e60b76621cd4acc5a6beaba733a8072 on wingyplus:change-get-pid into 848ee0b253e3c3af8ac605bb2b059398fdc4c3fb on Nebo15:master.

wingyplus commented 2 years ago

If this patch looks ok, I'll remove Elixir 1.8.0 on Travis CI. :)

AndrewDryga commented 2 years ago

@wingyplus thank you. This change looks good. I'll merge it before next major release because I feel like bumping elixir version might be an issue for some companies.

wingyplus commented 2 years ago

@AndrewDryga 🙇

wingyplus commented 2 years ago

@AndrewDryga May I know the plan when to release the major version?

Not a hurry issue. Just asking for information. :)

AndrewDryga commented 2 years ago

@wingyplus I was trying to wait for Elixir team to finish work they started doing of Elixir's Logger rewrite, after which it should support formatters and work mostly on Erlang's :logger back-end. I know this work has started a while ago but not sure how far it's from finishing

AndrewDryga commented 2 years ago

@wingyplus anyway we have other changes waiting for this so lets release it now :)

wingyplus commented 2 years ago

@AndrewDryga thanks :)