search

Nebo15 / sage

A dependency-free tool to run distributed transactions in Elixir, inspired by Sagas pattern.
MIT License
912 stars 40 forks source link

improve malformed transaction error messages #43

Closed superhawk610 closed 4 years ago

superhawk610 commented 4 years ago

This PR adds the stage name to Sage.MalformedTransactionReturnError and Sage.MalformedCompensationReturnError instances to improve usefuless when debugging.

BEFORE:

** (Sage.MalformedTransactionReturnError) expected transaction
#Function<0.11651793/2 in :erl_eval.expr/5> to return
{:ok, effect}, {:error, reason} or {:abort, reason}, got:

  :bad

AFTER:

** (Sage.MalformedTransactionReturnError) expected transaction
#Function<13.91303403/2 in :erl_eval.expr/5> for stage :foo to return
{:ok, effect}, {:error, reason} or {:abort, reason}, got:

  :bad
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 835cfdaed2d0f8e1c8d7a0137224cb1e0095a24b on superhawk610:feat/improve-malformed-error-messages into d801fda805c12ab745c693b5fb4d4a0839f3db1a on Nebo15:master.

AndrewDryga commented 4 years ago

👍 ❤️