feat: save snapshot with .gz extension

NebraLtd / hm-block-tracker

Helium Block Tracker enables "instant sync" functionality for Helium Hotspot Miners

MIT License

8 stars 5 forks source link

feat: save snapshot with .gz extension #90

Closed marvinmarnold closed 2 years ago

marvinmarnold commented 2 years ago

Issue

Link: https://nebraltd.slack.com/archives/C024BNQ1Y6T/p1652393225618449
Summary: Snapshot loading is broken on miners and we think its because of a change in expected filetype.

How Snapshot loading now expecting this extension. We think this will work even if the file is not actually compressed.

Screenshots

References

Checklist

[ ] Tests added
[ ] Cleaned up commit history (rebase!)
[ ] Documentation added
[ ] Thought about variable and method names

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

marvinmarnold commented 2 years ago

@pritamghanghas I couldn't find anywhere in code where we explicitly read from the snap-HEIGHT resource. My current guess is that that URL is generated based on the values in the sys.config.

pritamghanghas commented 2 years ago

@pritamghanghas I couldn't find anywhere in code where we explicitly read from the snap-HEIGHT resource. My current guess is that that URL is generated based on the values in the sys.config.

@marvinmarnold I tried to look at helium code base, It should end up using blessed_snapshot_block_height from sys.config as height for downloading.