Should Bluetooth led take precedence over error?

NebraLtd / hm-config

Helium Miner Config Container

https://nebra.io/hnt

MIT License

12 stars 20 forks source link

Should Bluetooth led take precedence over error? #187

Open shawaj opened 2 years ago

shawaj commented 2 years ago

Here I think the error LED takes precedence over the Bluetooth advertisement:

https://github.com/NebraLtd/hm-config/blob/d859a07efa230573a9f24e74265004e10eee6bee/gatewayconfig/processors/led_processor.py#L19-L30

I wonder if this should be the other way around? Not sure what you think @KevinWassermann94

KevinWassermann94 commented 2 years ago

Yeah, it should definetly be the other way around

shawaj commented 2 years ago

@marvinmarnold reckon we can change this?

marvinmarnold commented 2 years ago

Yea, reasonable change. We are also not using the concept of PF much anymore generally.

shawaj commented 2 years ago

@marvinmarnold do you think we should just get rid of PF here and move to checking the necessary diagnostics directly for the LED status?

marvinmarnold commented 2 years ago

I think they are different tickets. Bluetooth should take precedence regardless. Should also reconsider what the necessary diagnostics are. They should prob be things that impact earnings:

Internet connected? (not just E0 or W0)
Miner running? (not just ECC)
Lora running? (LOR is fine)

shawaj commented 2 years ago

Good point. I'll do a PR now and open a new ticket