search

NebraLtd / hm-config

Helium Miner Config Container
https://nebra.io/hnt
MIT License
14 stars 20 forks source link

Update Dockerfile #229

Closed shawaj closed 1 year ago

shawaj commented 1 year ago

Issue

How

Screenshots

References

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 72 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawaj commented 1 year ago

@KevinWassermann94 this build should fix the issue in #227 but it is a very hacky way of achieving this...before putting live on actual production units we should have radxa fix the actual debian package for libmraa on bullseye.

do you agree?

if so, we can roll back the config container in helium-miner-software and test with the older config container. then we can finish testing and deploy the diagnostics changes to production when we are ready and have documentation etc

pritamghanghas commented 1 year ago

just for my awareness, why do we need bullseye? Is there a LTS issue in current release?

KevinWassermann94 commented 1 year ago

@shawaj Yeah, let's wait for Radxa to fix it to make sure we don't run into any undetected issues

shawaj commented 1 year ago

just for my awareness, why do we need bullseye? Is there a LTS issue in current release?

Main reason was just because buster is EOL as of last year. I know it's on LTS but IMO it's better to use current stable wherever possible (although I realise that this is probably a contentious issue 😂). Especially given that Bookworm is on its way.

But also to unify the base images between all containers so the overall image size is reduced

shawaj commented 1 year ago

@shawaj Yeah, let's wait for Radxa to fix it to make sure we don't run into any undetected issues

👌