search

NebraLtd / hm-config

Helium Miner Config Container
https://nebra.io/hnt
MIT License
14 stars 20 forks source link

Improved gpio handling for buttons and status LEDs #230

Closed MuratUrsavas closed 1 year ago

MuratUrsavas commented 1 year ago

Issue

172

How If a user button or status led definition is missing in a variant definition, that part of the code is passed gracefully now.

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawaj commented 1 year ago

@MuratUrsavas in hm-pyhelper would we put: 'STATUS': False, and 'BUTTON': False, if they didn't exist? Or just leave them out entirely?

Or is either ok?

MuratUrsavas commented 1 year ago

@shawaj We have to leave them out as otherwise it would return something (False), and it would break current code and give exceptions. It depends on missing keys.

shawaj commented 1 year ago

@shawaj We have to leave them out as otherwise it would return something (False), and it would break current code and give exceptions. It depends on missing keys.

Ok perfect. So we just leave them out of pyhelper if no button or LED. Nice 👍

shawaj commented 1 year ago

I'll put a note on that repo to update the readme to reflect that https://github.com/NebraLtd/hm-pyhelper/issues/211