NebraLtd / hm-diag

Helium Miner Diagnostics
https://nebra.io/hnt
MIT License
21 stars 25 forks source link

Check for duplicate IP addresses and throw error #275

Open shawaj opened 2 years ago

shawaj commented 2 years ago

I had a customer where their unit had an IP address conflict - same IP for WiFi and Ethernet.

This stopped the miner from beaconing.

Upon fixing this is stated beaconing again.

If we detect the same IP address for wlan0 and eth0 we should throw an error

Related to #215

shawaj commented 2 years ago

Ref https://github.com/helium/miner/issues/1309#issuecomment-999159319

vpetersson commented 2 years ago

Hmm that's really a DHCP issue. The only "valid" use case where that could be it is if the WiFi and Ethernet are on different networks that are using the same network structure.

(Or a static IP issue as per above. Either way, i'd write this off as a user error as you'll have similar issues on any OS if you were to do this.)

shawaj commented 2 years ago

Agree it's not our fault.

But we can detect it and throw an error message to the user was what I meant