search

NebraLtd / hm-diag

Helium Miner Diagnostics
https://nebra.io/hnt
MIT License
21 stars 23 forks source link

Missing FREQ or VARIANT environment variables cause endpoints and requests to fail #289

Open MuratUrsavas opened 2 years ago

MuratUrsavas commented 2 years ago

I'm trying to test my branch and could not get response from the hm-diag application on a Raspberry Pi 3B+ test device. I'm aware that some hardware is missing on this device but the problem is worse because the app doesn't even respond to /version route.

The branch under test: https://github.com/NebraLtd/hm-diag/tree/murat/feat-add-short-git-sha

Here's the log I've collected: testfleet_ursavaspi-24.01.2214 06 22(+0300).zip

Edit Note: I can't access this device even locally, therefore running necessary commands from the terminal of Balena dashboard with the following command on Host:

$ curl -s localhost/version

The same command works on my dev machine while debugging the app locally.

MuratUrsavas commented 2 years ago

The problem is, diagnostics app is not working correctly if the VARIANT and FREQ variables cannot be found in environment variables. This can be easily avoided and reported in the config.

shawaj commented 1 year ago

Not sure if this issue is still happening and/or whether it's still relevant