NebraLtd / hm-diag

Helium Miner Diagnostics
https://nebra.io/hnt
MIT License
21 stars 23 forks source link

Make Diagnostics production parameter aware #468

Open MuratUrsavas opened 1 year ago

MuratUrsavas commented 1 year ago

Acceptance Criteria

shawaj commented 1 year ago

Related to #444

shawaj commented 1 year ago

@MuratUrsavas we need to make sure this works for non Nebra devices. Currently it fails...

https://github.com/NebraLtd/hm-pktfwd/issues/123

Maybe for non Nebra we can just have it put a value of none in the file?

shawaj commented 1 year ago

@MuratUrsavas I suppose the other way we could solve this is to just set all non-Nebra fleets to have a FREQ variable set to something like N/A (Non Nebra Miner)

Then we wouldn't need to make any code changes.

What do you think?

MuratUrsavas commented 1 year ago

@shawaj Actually I was expecting a mandatory FREQ parameter, but you're right. It has to be optional. Let me fix it.

shawaj commented 1 year ago

This one just fails silently already right @MuratUrsavas ?

https://github.com/NebraLtd/hm-diag/blob/master/setenv.sh

MuratUrsavas commented 1 year ago

@shawaj It's actually not failing. Just prompts an error if cannot reach them from both of the sources. But it continues to work if not exists.

shawaj commented 1 year ago

Perfect

shawaj commented 1 year ago

@MuratUrsavas @KevinWassermann94 guessing we can close this now?