Check and update readme, and document environment variable overrides and their usage

NebraLtd / hm-diag

Helium Miner Diagnostics

https://nebra.io/hnt

MIT License

21 stars 23 forks source link

Check and update readme, and document environment variable overrides and their usage #504

Open shawaj opened 1 year ago

shawaj commented 1 year ago

For example all of the ones defined here: https://github.com/NebraLtd/hm-diag/blob/23c66980f75568a4cecb18c5375a08cd67bff550/hw_diag/app.py#L34-L42

And also here: https://github.com/NebraLtd/hm-diag/blob/00f492a173e048bfbe9923c7497fa3e18d15632e/hw_diag/utilities/hardware.py#L216

There may be more elsewhere

shawaj commented 1 year ago

Related to #442

pritamghanghas commented 1 year ago

we should move all of them to a configuration module. There are too many and too spread out. Only downside is such a refactor will involve changing lot of test cases. But shouldn't be very hard to do. it will be easy to document and reference.