Remaining layout issues June

[shawaj]

Ip Addresses not obviously separated...

Footer still missing on small screen / mobile...

Side nav auto closes if you scroll down...

https://github.com/NebraLtd/hm-diag/assets/3359418/937a639d-0b5b-4856-9dae-7eb4653d80db

[shawaj]

Meta theme colour removed since hyper update...

Fixed by #594

[shawaj]

Large amount of empty space between content and footer on small screens...

[shawaj]

@KevinWassermann94 @WayneNebra @robputt crack any layout issues you find in the new diagnostics in here for @Louisreed

[shawaj]

Should add dark theme as per #475

[shawaj]

helium serial spills over edge of container...

[shawaj]

We should also fix #573 as part of this too...

[shawaj]

Also on upgrade page, the button is an odd colour and the whole thing is not responsive and does not fit smallish windows...

[Louisreed]

IP addresses are being displayed through {{ device_info.ip_address }}, no available option to filter

[Louisreed]

Unable to reproduce 'Side nav auto closes if you scroll down' error. Will require further testing on more devices. @shawaj is this just with chrome on Android?

[shawaj]

@Louisreed I've only tried on Chrome on Android on s23 ultra.

I can try on a different browser

Not sure if anyone has an iPhone to test with

[WayneNebra]

Same for me on an Android Oppo.

https://github.com/NebraLtd/hm-diag/assets/90446757/644149af-e8e4-4e38-bf77-08886bfad13b

[Louisreed]

Strange! I'll have to try with other devices. I have an iPad so will test on there as well.

[shawaj]

Same issue in iPhone 13 pro safari @Louisreed https://nebraltd.slack.com/archives/C024BNQ1Y6T/p1686242502586949

[shawaj]

IP addresses are being displayed through {{ device_info.ip_address }}, no available option to filter

@Louisreed can they be split out using JS or something? As presumably they have got spaces between them?

[Louisreed]

Issue resolved!

[Louisreed]

IP addresses are being displayed through {{ device_info.ip_address }}, no available option to filter

@Louisreed can they be split out using JS or something? As presumably they have got spaces between them?

Yeah I thought about using split() but would be better if I could directly access each IP. I'll see what I can do.

[shawaj]

@Louisreed ping @robputt on slack - he might know a better way to split these out in python and then just pull them in as an array or list or whatever

[shawaj]

Closed by #608 #615 #616