search

NebraLtd / hm-diag

Helium Miner Diagnostics
https://nebra.io/hnt
MIT License
21 stars 24 forks source link

Bump pydantic #646

Open shawaj opened 1 year ago

shawaj commented 1 year ago

Closes: #644

Issue

How

Screenshots

References

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawaj commented 1 year ago

@pritamghanghas since you originally worked on this(#404 #420 ), could you take a look?

Do we need to bump the diag schema and the relevant python files to include all of the new information available in the diagnostics JSON? Or this is not necessary?

pritamghanghas commented 1 year ago

I don't think anyone is using it. This was to upload the data to gcp bucket that triggers a function, that puts it in big query. I would say just retire it and save billing.

pritamghanghas commented 1 year ago

@KevinWassermann94 would know more if anyone is using the big query data for analysis. We have to keep in mind if more freeloaders join our fleets this will be unnecessary cost bump.

pritamghanghas commented 1 year ago

may be we should just change perform_hw_diagnostics(ship=True) to perform_hw_diagnostics(ship=False) in app.py and be done with it.

shawaj commented 1 year ago

@pritamghanghas Kevin says it's costing next to nothing and we do sometimes use it, albeit infrequently.

Do I need to modify it to actually provide all the data that's in the json JSON? Or how does it work?