search

NebraLtd / hm-gatewayrs

Light Hotspot (gateway-rs) Container for Helium
MIT License
5 stars 9 forks source link

Removed host networking necessity #43

Closed MuratUrsavas closed 1 year ago

MuratUrsavas commented 1 year ago

With the release of gateway-rs 1.0.1, we're now able to connect to API end point outside of the container. Hence removing host networking.

Also removed diagnostics check from start-gatewayrs.sh as it's breaking the dependency tree. Diagnostics is already depends on hm-gatewayrs. No need to create a dangerous reverse dependency as gateway-rs is just fine without diagnostics.

Checklist

shawaj commented 1 year ago

@MuratUrsavas the point of waiting for diagnostics is to make sure the key is programmed before trying to start the miner in production. This is very important IMO.

Also why are we putting some overrides in the dockerfile and others in the start script. Makes no sense to me?

MuratUrsavas commented 1 year ago

@shawaj Gonna open another PR and fix that now.