NebraLtd / hm-gatewayrs

Light Hotspot (gateway-rs) Container for Helium
MIT License
5 stars 9 forks source link

Fixed: Default region is undefined #44

Closed MuratUrsavas closed 1 year ago

MuratUrsavas commented 1 year ago

Checklist

shawaj commented 1 year ago

@MuratUrsavas why do we need awk anyway?

I think they changed it so that the default returns UNKNOWN now so we don't need this.

See #38

MuratUrsavas commented 1 year ago

@shawaj They started to return null at some point. And it was different before. I thought something should be wrong.

So is it null or UNKNOWN? It's safe to implement both, though.

shawaj commented 1 year ago

@MuratUrsavas why not even simpler then, like this? https://github.com/NebraLtd/hm-gatewayrs/pull/46

MuratUrsavas commented 1 year ago

@shawaj was thinking the same because somehow weirdly it sometimes return empty, too.