Eliminate usage of gen-region.sh

marvinmarnold commented 3 years ago

Services can now retrieve the region from the miner directly via hm_pyhelper.miner_json_rpc.get_region. There is no longer a need for gen-region.sh to write the region to file.

Acceptance criteria

hm-miner: Remove gen-region.sh and all references to it.
hm-pyhelper: Update logic in hm_pyhelper.miner_param.retry_get_region to invoke hm_pyhelper.miner_json_rpc.get_region instead of reading from file.
hm-pktfwd: Remove references to REGION_FILEPATH in hm-pktfwd.
Double check there are no other services that depend on the region file. At the time of writing, only hm-pktfwd uses this method.

shawaj commented 3 years ago

IIRC config at some point used it for outputting diagnostics info.

Other than that I think just UPnP

https://github.com/NebraLtd/hm-upnp/blob/56722295754eddc65496c3f08f0cb35e76ad0586/configureUpnp.py#L6-L22

shawaj commented 3 years ago

TBH the UPnP container is probably best to be deprecated in favour of hm-watchdog when we implement that IMO

Or we could stick the UPnP stuff in hm-config as that already has host networking set up in docker compose

shawaj commented 3 years ago

Diagnostics:

https://github.com/NebraLtd/hm-diag/blob/357372f7128ea1dcdade8dbb01f1554db2dfbff8/hw_diag/tasks.py#L67-L75

shawaj commented 3 years ago

Only problem with this, is that JSON RPC is unreliable...

https://github.com/NebraLtd/hm-diag/issues/195

NebraLtd / hm-miner

Eliminate usage of gen-region.sh #46