Sebastianmaj/gc vars - Githubissues

NebraLtd / hm-miner

Helium Miner Container

https://nebra.io/hnt

MIT License

16 stars 16 forks source link

Sebastianmaj/gc vars #69

Closed Kerrryu closed 2 years ago

Kerrryu commented 2 years ago

Issue

Link: https://github.com/NebraLtd/hm-miner/issues/62
Summary: Add storage limit for GC activation and limit the amount of latest blocks stored on the miner

How With firmware 2021.12.29.2 helium introduced 2 new variables in blockchain-core, these consist of BLOCKCHAIN_ROCKSDB_GC_BYTES in the environment file which is a bytes value for the limit on local storage of block data before GC is activated and blocks_to_protect_from_gc which is stored in sys.config and it tells the miner what's the limit on the number of recent blocks stored.

References

Checklist

[x] Cleaned up commit history (rebase!)
[ ] Documentation added
[ ] Thought about variable and method names

shawaj commented 2 years ago

will need to do corresponding updates in https://github.com/NebraLtd/hm-block-tracker as well (or these changes in the config file will just get overwritten when it pulls down from block-tracker)

Specifically in: https://github.com/NebraLtd/hm-block-tracker/blob/master/config.template

shawaj commented 2 years ago

Also should add some README information about the params and why we chose those values etc etc

KevinWassermann94 commented 2 years ago

The testnet is currently running 8GB and 10000 blocks to be protected. The storage usage seems to be maxing out around 17-18.5GB of storage usage with the garbage collection working 1-2 times per day cleaning around 1GB. The blockchain size still seems to be around 14GB, which leads to the conclusion that the 10000 blocks are the limiting factor.

I would like to reduce the protected blocks to 4000 to improve the storage usage and therefore the performance.

shawaj commented 2 years ago

4000 seems reasonable, pending testing

shawaj commented 2 years ago

PR in block tracker https://github.com/NebraLtd/hm-block-tracker/pull/60 (with 4000 in there)

shawaj commented 2 years ago

@SebastianMaj can you merge the block tracker one at same time?

Kerrryu commented 2 years ago

@SebastianMaj can you merge the block tracker one at same time?

Sorry was in a front end meeting with the team so I didn't see this message in time

Kerrryu commented 2 years ago

@shawaj Thank you for merging both

shawaj commented 2 years ago

No probs! Kevin wanted to get it in so just did it 😊