search

NebraLtd / hm-pktfwd

Helium Miner Packet Forwarder
https://nebra.io/hnt
MIT License
12 stars 25 forks source link

Revert to direct to Helium miner for now. #127

Closed robputt closed 1 year ago

robputt commented 1 year ago

Issue

How

Screenshots

References

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawaj commented 1 year ago

@robputt what's the purpose of this? Something not working?

robputt commented 1 year ago

@robputt what's the purpose of this? Something not working?

Apparently after some time hotspots stop forwarding packets from the multiplexer to the helium miner and they just blat out UDP error to the log. I am investigating but for now reverting. I think it hasn't been seen on my dev device because it doesn't stay online long enough without code pushes to see these affects. I'll try and get a fix in and deployed to the dev device before the weekend as I am away and then see if it's in this state when I get back :-).

shawaj commented 1 year ago

Oh ok, interesting. I did notice something similar but didn't realise it was all packets falling.

By the way, does the port need to change to something different?

shawaj commented 1 year ago

1680 isn't it @robputt ?

robputt commented 1 year ago

Oh ok, interesting. I did notice something similar but didn't realise it was all packets falling.

By the way, does the port need to change to something different?

Nah port is unrelated. They are already using non conflicti

1680 isn't it @robputt ?

shit, you right... let me raise another PR.

robputt commented 1 year ago

@shawaj https://github.com/NebraLtd/hm-pktfwd/pull/128