NebraLtd / hm-pktfwd

Helium Miner Packet Forwarder
https://nebra.io/hnt
MIT License
12 stars 25 forks source link

Updated sub regions (AS923_1C+, AU915_SB1, EU868_B+) #138

Closed MuratUrsavas closed 1 year ago

MuratUrsavas commented 1 year ago

Issue (https://nebraltd.atlassian.net/browse/NEBD-71) (Closes #118)

New sub region plans has been added. Some of the existing ones has been updated with notes.

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

MuratUrsavas commented 1 year ago

@pritamghanghas Yep! Actually EU868_x variants are all the same but they have probably prepared for some future changes.

shawaj commented 1 year ago

@MuratUrsavas we need to remove all the comments from the JSON files or it will break things.

We ran into this issue before... ref https://github.com/NebraLtd/hm-pktfwd/pull/106

shawaj commented 1 year ago

Also @MuratUrsavas you need to add them to here https://github.com/NebraLtd/hm-pktfwd/blob/master/pktfwd/config/region_config_filenames.py

MuratUrsavas commented 1 year ago

@shawaj Thanks for pointing them out.

MuratUrsavas commented 1 year ago

Done with #139