NebraLtd / hm-pktfwd

Helium Miner Packet Forwarder
https://nebra.io/hnt
MIT License
12 stars 25 forks source link

sx1302 fixes? #23

Closed shawaj closed 1 year ago

shawaj commented 3 years ago

We need to determine the reason for the sx1302 fixes and document it.

Additionally investigate if there is a better / more easily maintainable way of handling them.

shawaj commented 3 years ago

So this is needed to:

Config json setting: https://github.com/NebraLtd/hm-pktfwd/blob/9d37e8446103380aa8257cd625dd8e3ce63e52c7/sx1302fixes/lora_pkt_fwd.c#L74-L75

Fixed temp: https://github.com/helium/sx1302_hal/commit/f33a6e3e2572e198ac1db8d1f4317a393c5c38a1#diff-f7c83d3744b9002047a15dd7a655dc21a24aa9aa6933bb29229370429e900813

shawaj commented 3 years ago

This file isn't currently used https://github.com/NebraLtd/hm-pktfwd/blob/master/sx1302fixes/loragw_gps.c

Need to investigate further why (need to diff with the upstream file https://github.com/Lora-net/sx1302_hal/blob/master/libloragw/src/loragw_gps.c and also https://github.com/RAKWireless/rak_common_for_gateway/blob/master/lora/rak2287/loragw_gps.c )

Lastly check https://github.com/RAKWireless/rak_common_for_gateway/blob/master/lora/rak2287/install.sh

shawaj commented 3 years ago

See also https://github.com/NebraLtd/packet_forwarder/issues/1 and https://github.com/NebraLtd/lora_gateway/issues/1

shawaj commented 2 years ago

FYI https://github.com/Lora-net/sx1302_hal/issues/58 and https://github.com/Lora-net/sx1302_hal/pull/60 and https://github.com/Lora-net/sx1302_hal/pull/63

shawaj commented 2 years ago

Guess we can probably close this now @marvinmarnold what do you think?

marvinmarnold commented 2 years ago

That makes sense. Do you understand all the changes in this commit? That commit is basically everything that used to be in the sx1302/ directory of this repo.

I would need to carefully go back over all the links above to double check that we understand every single diff. Do you have a better grasp?