NebraLtd / hm-pktfwd

Helium Miner Packet Forwarder
https://nebra.io/hnt
MIT License
12 stars 24 forks source link

Don't think reset_lgw.sh is used? #27

Closed shawaj closed 2 years ago

shawaj commented 2 years ago

In the files we have two reset scripts:

Here, we sed the pin number for reset into the reset_lgw.sh script: https://github.com/NebraLtd/hm-pktfwd/blob/master/files/configurePktFwd.py#L125-L128

But we never actually use that script, and instead are using reset-v2.sh: https://github.com/NebraLtd/hm-pktfwd/blob/master/files/configurePktFwd.py#L130-L160

In the dockerfile we copy the reset_lgw.sh script over twice. Once here: https://github.com/NebraLtd/hm-pktfwd/blob/master/Dockerfile#L93-L95

And the other time here: https://github.com/NebraLtd/hm-pktfwd/blob/master/Dockerfile#L107-L109

I am pretty sure this is unnecessary, but need to test some more that it is not required for properly starting an sx1302/sx1303 based concentrator.

shawaj commented 2 years ago

ok so the reset_lgw.sh file is only used by the chip_id program to reset the gateway when trying to determine the EUI

https://github.com/Lora-net/sx1302_hal/blob/master/util_chip_id/src/chip_id.c#L151-L157

What I am still not clear on is why we need to use reset-v2 as well when the reset is already done by reset_lgw