NebraLtd / hm-pktfwd

Helium Miner Packet Forwarder
https://nebra.io/hnt
MIT License
12 stars 24 forks source link

All-in-one build total refactor #58

Closed marvinmarnold closed 2 years ago

marvinmarnold commented 2 years ago

Why The build process is confusing. This is one of two proposals on how to structure the Dockerfile in order to improve things.

How One anti-pattern in how things are done currently is that this Dockerfile is responsible for building other repositories, specifically nebraltd/packet_forwarder and nebraltd/lora_gateway. This PR copies those libraries directly into source control. Copying libraries using git clone within the Dockerfile should always be avoided IMHO.

The other proposal builds lora_gateway and packet_forwarder independently.

References

marvinmarnold commented 2 years ago

The decision is to build all dependent projects (nebraltd/lora_gateway, nebraltd/packet_forwarder, and nebraltd/sx1302_hal) in their respective repos and reference built assets from hm-pktfwd. Will open a new PR that implements like that.