NebraLtd / hm-pktfwd

Helium Miner Packet Forwarder
https://nebra.io/hnt
MIT License
12 stars 24 forks source link

fix: copy configs to correct locations #74

Closed shawaj closed 2 years ago

shawaj commented 2 years ago

Why

fix: copy configs to correct locations

How

References

Relates-to: #70 Relates-to: #72

shawaj commented 2 years ago

Should be merged at same time as #72

shawaj commented 2 years ago

@marvinmarnold yeah maybe that's a better way to do it - just have the single config.

I'm trying to think if there is any particular reason / scenario in which we would want to use a local_conf.json

The only thing I can think of is optionally adding features like GPS based on whether there is a GPS module available for example. But I guess we could always do that like we are doing with SPI bus by injecting JSON objects

Also less confusing if it's all in a single config file

(And I guess we can always add in local_conf.json stuff later if we change our minds)

marvinmarnold commented 2 years ago

I'm trying to think if there is any particular reason / scenario in which we would want to use a local_conf.json

(And I guess we can always add in local_conf.json stuff later if we change our minds)

@shawaj I don't have a strong opinion, there are merits of both ways. This method is already complete, which is always a +1.

shawaj commented 2 years ago

@marvinmarnold let's leave it as is now then. The one benefit to having the local_conf.json I guess is that we can override those parameters without editing every regional file, for example