Closed shawaj closed 2 years ago
Should be merged at same time as #72
@marvinmarnold yeah maybe that's a better way to do it - just have the single config.
I'm trying to think if there is any particular reason / scenario in which we would want to use a local_conf.json
The only thing I can think of is optionally adding features like GPS based on whether there is a GPS module available for example. But I guess we could always do that like we are doing with SPI bus by injecting JSON objects
Also less confusing if it's all in a single config file
(And I guess we can always add in local_conf.json stuff later if we change our minds)
I'm trying to think if there is any particular reason / scenario in which we would want to use a local_conf.json
(And I guess we can always add in local_conf.json stuff later if we change our minds)
@shawaj I don't have a strong opinion, there are merits of both ways. This method is already complete, which is always a +1.
@marvinmarnold let's leave it as is now then. The one benefit to having the local_conf.json I guess is that we can override those parameters without editing every regional file, for example
Why
fix: copy configs to correct locations
How
References
Relates-to: #70 Relates-to: #72