search

NebraLtd / hm-pyhelper

A helper module used across various Nebra repos to reduce redundant features.
https://nebra.io/hmpyhelper
MIT License
8 stars 16 forks source link

gateway-mfr-rs: Update to latest release v0.2.1 #148

Closed mr-bump closed 2 years ago

mr-bump commented 2 years ago

Update gateway-mfr-rs to latest release v0.2.1 Ref https://github.com/helium/gateway-mfr-rs/releases/tag/v0.2.1

shawaj commented 2 years ago

Just FYI this update essentially adds the ability to specify a devices i2c bus, i2c address and slot to program... https://github.com/helium/gateway-mfr-rs/pull/12#issue-1124666861

And README here ... https://github.com/helium/gateway-mfr-rs/commit/fbc4e084868f53294227fa4f51c37b38e3f6b85d

Looks like we may need to update some of the work in #84 to bring in this new format of the ECC device specification perhaps by changing KEY_STORAGE_BUS to KEY_STORAGE_ADDRESS and specifying the whole address such as ecc://i2c-1:96?slot=0 instead of just /dev/i2c-1

https://github.com/NebraLtd/hm-pyhelper/blob/ffeeb3b4e200e28f0887618b489411aea184072f/hm_pyhelper/hardware_definitions.py#L37

shawaj commented 2 years ago

Yes we shouldn't merge yet @pritamghanghas we need to fix the things mentioned in above comment https://github.com/NebraLtd/hm-pyhelper/pull/148#issuecomment-1114087141

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information