Rename hardware definitions

NebraLtd / hm-pyhelper

A helper module used across various Nebra repos to reduce redundant features.

https://nebra.io/hmpyhelper

MIT License

9 stars 16 forks source link

Rename hardware definitions #171

Closed KevinWassermann94 closed 2 years ago

KevinWassermann94 commented 2 years ago

Format: vendor-model

Acceptance Criteria:

[ ] All current hardware variants need to be kept
[ ] Duplicate hardware variants and rename to new format
[ ] nebra-indoor1
[ ] nebra-indoor2
[ ] nebra-outdoor1
[ ] rak-fl1
[ ] helium-fl1
[ ] sensecap-fl1
[ ] panther-fl1
[ ] finestra-fl1
[ ] pisces-fl1
[ ] cotx-fl1
[ ] PR Open, not required to be pushed

pritamghanghas commented 2 years ago

according to @KevinWassermann94, only these translations matter: 'NEBHNT-IN1' -> 'nebra-indoor1' 'NEBHNT-OUT1' -> 'nebra-outdoor1' 'NEBHNT-HHRK4' -> 'nebra-indoor2' 'NEBHNT-HHRK4-OUT' -> 'nebra-outdoor2' 'COMP-RAKHM' -> 'rak-v1' 'COMP-HELIUM' -> 'helium-v1' 'COMP-SENSECAPM1' -> 'senscap-v1' 'COMP-PANTHERX1' -> 'panther-v1' 'COMP-FINESTRA' -> 'finestra-v1' 'COMP-PISCESP100' -> 'pisces-v1' 'COMP-COTX3' -> 'cotx3-v1'

KevinWassermann94 commented 2 years ago

@pritamghanghas As we figured out we should also create these for the light hotspots. The RasPi one should be nebra-light1 and the RockPi nebra-light2

pritamghanghas commented 2 years ago

@KevinWassermann94 whats the deal with last ac "PR Open, not required to be pushed". Open how long? What will be a trigger to merge?

vpetersson commented 2 years ago

We need to time this with the fleet renaming. While we do have pinned releases it's to avoid accidentally bumping to this release.

pritamghanghas commented 2 years ago

@KevinWassermann94 Shall we add the arch and balena_devicetype to this description. Will be handy if we plan to create fleets using cli.

KevinWassermann94 commented 2 years ago

@pritamghanghas That would make sense, good idea!

marvinmarnold commented 2 years ago

@pritamghanghas going to add fl to the fleets instead of v

pritamghanghas commented 2 years ago

@marvinmarnold @shawaj Does it look ok now. There are no good choices here. The variant name is independent of the model name (using "fl" suffix instead of v) and supported model names and device names are included in variant structure

pritamghanghas commented 2 years ago

increased points from 1 to 3. As it took lot of iterations and careful testing that everything is good.

marvinmarnold commented 2 years ago

@KevinWassermann94 can we get customer support to validate this in testnet?