feat: Rename hardware definitions #171

NebraLtd / hm-pyhelper

A helper module used across various Nebra repos to reduce redundant features.

https://nebra.io/hmpyhelper

MIT License

8 stars 16 forks source link

feat: Rename hardware definitions #171 #172

Closed pritamghanghas closed 2 years ago

pritamghanghas commented 2 years ago

renamed variants in preparation for fleet consolidation.

Issue

Link: https://github.com/NebraLtd/hm-pyhelper/issues/171
Summary: renamed variants in preparation for fleet consolidation.

How

Screenshots

References

Checklist

[ ] Tests added
[ ] Cleaned up commit history (rebase!)
[x] Documentation added
[x] Thought about variable and method names

shawaj commented 2 years ago

This change seems pretty major and will break other people's fleets if they are using our hm-pyhelper

I don't see any real benefit in breaking things in this way to be honest. If there's no real benefit to it, and can break things - what's the point?

shawaj commented 2 years ago

Sorry I should have looked at the backward compatibility at the bottom...

But still, what's the point?

pritamghanghas commented 2 years ago

To remove confusions with v1 and vn, we name fleets with -fl1, -fl2, ... -fln as discussed in one of the meetings and nebra devices are named -indoor1, -outdoor1, -light1 etc.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

posterzh commented 2 years ago

Good job. Looks good. :slightly_smiling_face: