NebraLtd / hm-pyhelper

A helper module used across various Nebra repos to reduce redundant features.
https://nebra.io/hmpyhelper
MIT License
9 stars 16 forks source link

feat: Create new Fleets for all variants #1090 #173

Closed pritamghanghas closed 1 year ago

pritamghanghas commented 2 years ago

Create new Fleets for all variants #1090

Screenshots

References

Checklist

shawaj commented 2 years ago

Also relates to #98

shawaj commented 2 years ago

@marvinmarnold what do you think about just removing hardware that we have no current plans to manufacture?

For example tinkerboard ones etc

Unless we want to support them DIY, which we currently aren't planning either, perhaps we should remove them and can just add them back in later if anything changes

pritamghanghas commented 2 years ago

fixed review comments.

MuratUrsavas commented 2 years ago

@pritamghanghas Coul you also add nebra-light3 and nebra-outdoor2 so my changes on helium-miner-software would not fail.

For nebra-outdoor2, just copy the nebra-indoor2. For the nebra-light3, you can either copy nebra-light2 and let me fix it later with another PR, or get the information from the hardware-designs repo or directly from me.

MuratUrsavas commented 2 years ago

@pritamghanghas Please see https://github.com/NebraLtd/hm-pyhelper/tree/murat/add-nebra-light-2-and-3

I'm leaving merging to you. Feel free to delete it after merging it here.

pritamghanghas commented 2 years ago

@shawaj I have updated them as per discussions.

pritamghanghas commented 2 years ago

@MuratUrsavas @posterzh @MuratUrsavas @vpetersson I have added fleet creation script as well. This is a helper script. Not adding this to workflow yet. Tested on a private account. Seems to be working well. Will test on the NebraLtd org, once I have permissions. It uses a template repository that will become part of nebraltd with this pull request

pritamghanghas commented 2 years ago

@pritamghanghas Please see https://github.com/NebraLtd/hm-pyhelper/tree/murat/add-nebra-light-2-and-3

I'm leaving merging to you. Feel free to delete it after merging it here.

I have added those. Let me know if there is any mistake.

MuratUrsavas commented 2 years ago

I have added those. Let me know if there is any mistake.

All good :+1:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pritamghanghas commented 2 years ago

@pritamghanghas Coul you also add nebra-light3 and nebra-outdoor2 so my changes on helium-miner-software would not fail.

For nebra-outdoor2, just copy the nebra-indoor2. For the nebra-light3, you can either copy nebra-light2 and let me fix it later with another PR, or get the information from the hardware-designs repo or directly from me.

@pritamghanghas Please see https://github.com/NebraLtd/hm-pyhelper/tree/murat/add-nebra-light-2-and-3

I'm leaving merging to you. Feel free to delete it after merging it here.

done