Closed pritamghanghas closed 1 year ago
Also relates to #98
@marvinmarnold what do you think about just removing hardware that we have no current plans to manufacture?
For example tinkerboard ones etc
Unless we want to support them DIY, which we currently aren't planning either, perhaps we should remove them and can just add them back in later if anything changes
fixed review comments.
@pritamghanghas Coul you also add nebra-light3
and nebra-outdoor2
so my changes on helium-miner-software
would not fail.
For nebra-outdoor2
, just copy the nebra-indoor2
. For the nebra-light3
, you can either copy nebra-light2
and let me fix it later with another PR, or get the information from the hardware-designs
repo or directly from me.
@pritamghanghas Please see https://github.com/NebraLtd/hm-pyhelper/tree/murat/add-nebra-light-2-and-3
I'm leaving merging to you. Feel free to delete it after merging it here.
@shawaj I have updated them as per discussions.
@MuratUrsavas @posterzh @MuratUrsavas @vpetersson I have added fleet creation script as well. This is a helper script. Not adding this to workflow yet. Tested on a private account. Seems to be working well. Will test on the NebraLtd org, once I have permissions. It uses a template repository that will become part of nebraltd with this pull request
@pritamghanghas Please see https://github.com/NebraLtd/hm-pyhelper/tree/murat/add-nebra-light-2-and-3
I'm leaving merging to you. Feel free to delete it after merging it here.
I have added those. Let me know if there is any mistake.
I have added those. Let me know if there is any mistake.
All good :+1:
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@pritamghanghas Coul you also add
nebra-light3
andnebra-outdoor2
so my changes onhelium-miner-software
would not fail.For
nebra-outdoor2
, just copy thenebra-indoor2
. For thenebra-light3
, you can either copynebra-light2
and let me fix it later with another PR, or get the information from thehardware-designs
repo or directly from me.@pritamghanghas Please see https://github.com/NebraLtd/hm-pyhelper/tree/murat/add-nebra-light-2-and-3
I'm leaving merging to you. Feel free to delete it after merging it here.
done
Create new Fleets for all variants #1090
How
Screenshots
References
Checklist