NebraLtd / hm-pyhelper

A helper module used across various Nebra repos to reduce redundant features.
https://nebra.io/hmpyhelper
MIT License
9 stars 16 forks source link

feat: bump protobuf to 4.21.12 #207

Closed shawaj closed 1 year ago

shawaj commented 1 year ago

Issue

How

Screenshots

References

Checklist

shawaj commented 1 year ago

had to regenerate protos using protoc - however not sure I have done it correctly.

@NebraLtd/developers I don't suppose any of you have experience with protobuf / protoc? And would be able to check this

pritamghanghas commented 1 year ago

@shawaj Not sure what was the reason for updating protobuff but I don't see any issues.

shawaj commented 1 year ago

No real reason @pritamghanghas other than for it to be on latest up to date versions

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawaj commented 1 year ago

will merge this without version update, and then update version in #208