NebraLtd / hm-pyhelper

A helper module used across various Nebra repos to reduce redundant features.
https://nebra.io/hmpyhelper
MIT License
9 stars 16 forks source link

Removed grpcio direct requirement #242

Closed MuratUrsavas closed 1 year ago

MuratUrsavas commented 1 year ago

As this package creates a lot of long time build issues I've removed direct dependency from here to let parent app decide which grpcio version to use.

Checklist

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawaj commented 1 year ago

Wouldn't it be better to just use a >= here instead of removing it altogether? (Or just no specific version and just using grpcio)

Because it is a dependency and we surely need at least some version of it?

shawaj commented 1 year ago

@MuratUrsavas it seems minimum we are using is 1.50.1 so can't we just say grpcio>=1.50.1 ?

MuratUrsavas commented 1 year ago

@shawaj I thought if a newer version is available then it would be used despite it would need a compilation. But now I've tested it and you're right. This way it leaves it as it is. Let me take care of it :+1:

shawaj commented 1 year ago

Awesome, yeah I think it will use any wheels that fit the requirements first, and if it can't find any wheels that fit then it will build from source