search

NebraLtd / hm-pyhelper

A helper module used across various Nebra repos to reduce redundant features.
https://nebra.io/hmpyhelper
MIT License
8 stars 16 forks source link

Should we be using full instead of light for add gateway? #252

Open shawaj opened 1 year ago

shawaj commented 1 year ago

Light doesn't exist anymore. I think we should be using full?

Ref

https://github.com/NebraLtd/hm-pyhelper/blob/431c825963a8d13d96fdf5ff73953e0bcb27a1eb/hm_pyhelper/gateway_grpc/client.py#L95

And

https://github.com/NebraLtd/hm-pyhelper/blob/431c825963a8d13d96fdf5ff73953e0bcb27a1eb/protos/gateway_staking_mode.proto#L7

shawaj commented 1 year ago

@pritamghanghas @MuratUrsavas @KevinWassermann94 can you take a look?

KevinWassermann94 commented 1 year ago

@shawaj Yes, light has been removed and should be replaced by full

shawaj commented 1 year ago

@pritamghanghas @MuratUrsavas does line 95 in the first linked file need to be changed to .full at the end?