NebraLtd / maker-starter-app

Apache License 2.0
2 stars 2 forks source link

Antenna fee is not 0 #161

Closed marvinmarnold closed 2 years ago

marvinmarnold commented 2 years ago

IIRC antenna fee is $0.55

Acceptance Criteria

marvinmarnold commented 2 years ago

@Andrewsopoku can you add a screenshot for @Louisreed to make some adjustments to?

Andrewsopoku commented 2 years ago

Simulator Screen Shot - iPhone 13 - 2022-05-30 at 20 57 26

marvinmarnold commented 2 years ago

@Andrewsopoku can you open a PR for a new release and push to Test Flight?

Andrewsopoku commented 2 years ago

@marvinmarnold unexpectedly, i am able to still reproduce the issue when i open antenna update for the first time but the correct fee gets set on subsequent opening. I moved the ticket to in-progress because i am still figuring out what is causing the issue. The easiest fix would be hardcoding the fee since we already know and opening a follow up ticket for a proper fix.

Thoughts?

marvinmarnold commented 2 years ago

That sounds good to me. @KevinWassermann94?

KevinWassermann94 commented 2 years ago

@Andrewsopoku @marvinmarnold That sounds good to me. Let's hardcode 55k DC (0.55$) as that's the limit. It wouldn't hurt anyone if they end up paying less

marvinmarnold commented 2 years ago

Published v1.0.5 to both stores. Waiting on approval.