search

Nebual / NadmodPP

NPP - Simple Prop Protection for Garry's Mod servers
5 stars 7 forks source link

delete this PR #12

Closed Kilometres closed 1 year ago

Kilometres commented 1 year ago

someone delete this PR please

Kilometres commented 1 year ago

meant to open this in a fork and can't delete the PR, my bad

Nebual commented 1 year ago

Huh, neat that people still use this enough to fork it! If @Derpius and you want to merge your changes into this repo (and I can remember how to update workshop), feel free to PR here.

I'll close this for now as requested

Derpius commented 1 year ago

@Nebual re. merging the changes, I've applied our common Lua tooling to both files (and added CI including deploying to our infrastructure, but that could be removed) so I'm not sure merging in our master is desired?

We're additionally in the process of making changes to remove the admin bypass, while still allowing deleting entities (primarily for E2/Starfall) which I imagine doesn't want merging here.

I could create a separate branch that removes any TAS-specific changes while keeping the tooling and lint CI pipelines and PR that instead if you'd like?