search

Nebukam / PCGExtendedToolkit

PCGEx is a free (libre) Unreal 5 plugin that expands PCG capabilities. It offers a variety of high-performance nodes; with an edge for building relational graphs (Freeform, Delaunay, Voronoi, MST etc), advanced pathfinding; and much more.
MIT License
131 stars 14 forks source link

Shipping build issues #53

Closed paulash closed 2 months ago

paulash commented 3 months ago

There are a number of issues with shipping builds, starting with 'settings' is a non-redistributable module. There are a handful of function declaration that are opt'd out without editor, but the definition is not, and there are many many usages of FORCEINLINE that are incorrectly defined and break with shipping builds.

Nebukam commented 3 months ago

Will look into this, thanks! What platform are you on?

paulash commented 3 months ago

Win64, but these issues would effect shipping on any platform.

Nebukam commented 3 months ago

Not to state the obvious but it's been a while o haven't sanity checked with shipping; sorry about that 😅

paulash commented 3 months ago

Understandable; not really meant for production yet, just ran into issues when we started using our build server to run test cases.

Nebukam commented 3 months ago

I think I fixed all of the issues on the cluster-feature branch; I was able to package a build locally without warning nor errors -- HOWEVER, this branch contains a very large number of breaking updates, is not bug-free when it comes to some nodes. I've been doing a thorough refactoring of things and it's not 100% ready yet. That is, API/names won't change from there, so it's safe to use and update, and it should at least allow you to ease PCGEx into your build pipeline.

tychotic commented 2 months ago

Thanks Tim - a good checkpoint for me would be when the example code (specifically voronois + contours) are working, that's my only current blocker.

Many thanks, Matthew

On Tue, Jul 2, 2024 at 9:00 PM Tim @.***> wrote:

I think I fixed all of the issues on the cluster-feature branch; I was able to package a build locally without warning nor errors -- HOWEVER, this branch contains a very large number of breaking updates, is not bug-free when it comes to some nodes. I've been doing a thorough refactoring of things and it's not 100% ready yet. That is, API/names won't change from there, so it's safe to use and update, and it should at least allow you to ease PCGEx into your build pipeline.

— Reply to this email directly, view it on GitHub https://github.com/Nebukam/PCGExtendedToolkit/issues/53#issuecomment-2205049211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUHSCL3RRXDMEY5IWNW5TG3ZKNZPHAVCNFSM6AAAAABKIHCXJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGA2DSMRRGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Nebukam commented 2 months ago

Hey there @tychotic & @paulash :) Merged the massive (228 commit ugh) branch to the main and tagged a pre-release which hopefully will allow you to move forward.

Again, there is a tremendous lot of changes & refactors in this branch, it may introduce new bugs while some old ones are fixed, and will very likely break any existing graph. I've noticed that some updated nodes can cause crashes if they're not entierely deleted and recreated (Fuse cluster being one of those).

Also -- both voronoi & find contours have been updated 😬

I've checked in shipping on win64 and for what it's worth... "It WoRks On My MaChIne" ^^'

Edit: Updated the example project as well.

mattmac-blv commented 2 months ago

You’re an amazing human. I’ll give it a shake tomorrow.

On Tue, Jul 9, 2024 at 8:33 PM Tim @.***> wrote:

Hey there @tychotic https://github.com/tychotic & @paulash https://github.com/paulash :) Merged the massive (228 commit ugh) branch to the main and tagged a pre-release https://github.com/Nebukam/PCGExtendedToolkit/tree/v0.16-preview.1 which hopefully will allow you to move forward.

Again, there iwas a tremendous lot of changes & refactors in this branch, it may introduce new bugs while some old ones are fixed, and will very likely break any existing graph. I've noticed that some updated nodes can cause crashes if they're not entierely deleted and recreated (Fuse cluster being one of those).

Also -- both voronoi & find contours have been updated 😬

I've checked in shipping on win64 and for what it's worth... "It WoRks On My MaChIne" ^^'

— Reply to this email directly, view it on GitHub https://github.com/Nebukam/PCGExtendedToolkit/issues/53#issuecomment-2219477408, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAW37WO5FWXD4HW3X3N5D2TZLSTQ3AVCNFSM6AAAAABKIHCXJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZGQ3TONBQHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Nebukam commented 2 months ago

Ahoy! I pushed another update that fixes a few bugs/problematic edge cases with Find Contours (amongst other things), tagged a pre-release with it.

Please let me know if you issues are fixed so I can close the two issues!

Nebukam commented 2 months ago

Closing since there hasn't been any news on this and the big update is live ;)