search

Nebula83 / openhab2-addons

Add-ons for openHAB 2.x
Eclipse Public License 1.0
8 stars 2 forks source link

Fix set point and also change IDs to String #7

Closed foxy82 closed 7 years ago

foxy82 commented 7 years ago

Hey,

So in this commit I've changed all IDs to be Strings - we receive it as a String never have to do any maths on them and with the weird formatting that is happening I think this is safest.

I've also fixed the set point and duplicated the channel - one is read only so nice and easy to see in the PaperUI the other is read/write but not implemented yet.

Nebula83 commented 7 years ago

Cool beans! Btw, since setting mode and reading temps are working now, could we initiate a PR on the main repo? I think it is V1 worthy?

foxy82 commented 7 years ago

Yeah I think so - although we probably want to hide the setting temp channel (set point) whilst we figure out how best to implement it.

This binding now does all the original did except weather which isn't in the new V2 api.

foxy82 commented 7 years ago

I've commented out the set point channel - not tested it but it should work.

Nebula83 commented 7 years ago

Yeah that would be best I think. About the weather; I can't seem to locate it in the V2 API as well. Is that important to you? I am using the weather (wunderground) binding and I'm pretty happy with it

Nebula83 commented 7 years ago

Hi @foxy82, I haven't received a reply yet on my questions. Maybe your away for a bit, no problem. I'll check on the issues I found myself and test the available channel so that I can raise a PR on the main repo.

foxy82 commented 7 years ago

Sorry I missed this. Thanks. Although I wonder if I should leave as text as it is read only...

On 7 Jun 2017 10:23 am, "Nebula83" notifications@github.com wrote:

@Nebula83 commented on this pull request.

In addons/binding/org.openhab.binding.evohome/ESH-INF/thing/channels.xml https://github.com/Nebula83/openhab2-addons/pull/7#discussion_r120575273 :

     <category>heating</category>

Spaces needed to be removed. I fixed it in my last commit (pushed)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Nebula83/openhab2-addons/pull/7#discussion_r120575273, or mute the thread https://github.com/notifications/unsubscribe-auth/AHZY9KTxk4HMEw5nWZH_Lti9rkFSHhqjks5sBmwUgaJpZM4NuNvu .

Nebula83 commented 7 years ago

No problem, don't worry. I'd leave it as option. Paper UI now shows Permanent Override instead of PermanentOverride. It separates presentation from business view, which I like.