Closed starfi5h closed 9 months ago
Why is CommonAPI still included as a soft dependency then? Do we leverage it at all after this PR?
The soft dependency is added to preserve the load order that Nebula is loaded after CommonAPI. I'm not sure if CommonAPI has code that is sensitive to load order, so maybe it can be removed?
As for usage, here are some warnings from chatwindow after disable CommonAPI
[Warning: Unity Log] The referenced script (CommonAPI.UIWindowResize) on this Behaviour is missing!
[Warning: Unity Log] The referenced script (CommonAPI.MaterialFixer) on this Behaviour is missing!
[Warning: Unity Log] The referenced script on this Behaviour (Game Object 'ChatV2') is missing!
So after this PR, Nebula can run without CommonAPI but with less features. Whether to include CommonAPI in thunderstore dependencies can be discussed.
CreateHotkeyControl
to support KeyboardShortcut type in MultiplayerOptions. The available Keycode string can be found in Unity Doc. The input text will turn red if it is invalid.