NebulaSS13 / Nebula

A general purpose SS13/Baystation12 fork.
https://discord.gg/Ddw58yF
GNU Affero General Public License v3.0
49 stars 220 forks source link

disappearing stack of bricks after splitting #1067

Closed SolatK closed 3 years ago

SolatK commented 3 years ago

Description of issue

A stack of bricks disappear when you drop it

Difference between expected and actual behavior

It shouldnt

Steps to reproduce

1) Mine some phosphorite 2) Process it with ore processor 3) Stack with stacker 4) Take it in your hand изображение

5) Split 6) You have a stack without amount number изображение If you drop it you will lose it BUT you can use it изображение

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Issue bingo

MistakeNot4892 commented 3 years ago

Getting a runtime when splitting the stack:

[18:04:56] Runtime in atoms_movable.dm,152: Attempted to forceMove a QDELETED the phosphorite brick out of nullspace!!!
  proc name: forceMove (/atom/movable/proc/forceMove)
  usr: Cecily Byers (/mob/living/carbon/human) ([0x300004b]) (the floor) (39,42,2 - Tradeship Ocelot Alpha) (/turf/simulated/floor/tiled) (mistakenot4892)
  usr.loc: The floor (/turf/simulated/floor/tiled) ([0x10025f6]) (39,42,2 - Tradeship Ocelot Alpha) (/area/ship/trade/cargo/lower)
  src: the phosphorite brick (/obj/item/stack/material/generic)
  src.loc: null
  call stack:
  the phosphorite brick (/obj/item/stack/material/generic): forceMove(Cecily Byers (/mob/living/carbon/human))
  the phosphorite brick (/obj/item/stack/material/generic): forceMove(Cecily Byers (/mob/living/carbon/human))
  the phosphorite brick (/obj/item/stack/material/generic): forceMove(Cecily Byers (/mob/living/carbon/human))
  Cecily Byers (/mob/living/carbon/human): equip to slot(the phosphorite brick (/obj/item/stack/material/generic), "r_hand", 1)
  Cecily Byers (/mob/living/carbon/human): equip to slot if possible(the phosphorite brick (/obj/item/stack/material/generic), "r_hand", 0, 0, 1, 0)
  Cecily Byers (/mob/living/carbon/human): put in active hand(the phosphorite brick (/obj/item/stack/material/generic))
  Cecily Byers (/mob/living/carbon/human): put in hands(the phosphorite brick (/obj/item/stack/material/generic))
  the phosphorite bricks (/obj/item/stack/material/generic): attack hand(Cecily Byers (/mob/living/carbon/human))
  Cecily Byers (/mob/living/carbon/human): UnarmedAttack(the phosphorite bricks (/obj/item/stack/material/generic), 1)
  Cecily Byers (/mob/living/carbon/human): ClickOn(the phosphorite bricks (/obj/item/stack/material/generic), "icon-x=15;icon-y=11;vis-x=15;v...")
  /datum/click_handler/default (/datum/click_handler/default): OnClick(the phosphorite bricks (/obj/item/stack/material/generic), "icon-x=15;icon-y=11;vis-x=15;v...")
  the phosphorite bricks (/obj/item/stack/material/generic): Click(null, "mapwindow.map", "icon-x=15;icon-y=11;vis-x=15;v...")