NebulaSS13 / Nebula

A general purpose SS13/Baystation12 fork.
https://discord.gg/Ddw58yF
GNU Affero General Public License v3.0
52 stars 221 forks source link

Space turfs do not update their ambient light when a dynamically lit turf is created beside them. #2746

Open MistakeNot4892 opened 2 years ago

MistakeNot4892 commented 2 years ago

Description of issue

See title.

Difference between expected and actual behavior

Space turfs only generate/apply ambient light when they are bordering a dynamically lit turf, as otherwise you would have thousands of space turfs pointlessly creating corners etc. However as it stands, they should be updated when a dynamically lit turf is created beside them.

Steps to reproduce

Specific information for locating

I believe this was previously handled in simulated turf init, but not sure.

Length of time in which bug has been known to occur

Presumably since ambient lights were added..

Client version, Server revision & Game ID

Current dev.

Issue bingo

out-of-phaze commented 5 months ago

Space turfs only generate/apply ambient light when they are bordering a dynamically lit turf

? this doesn't make sense to me, space turfs have ambient light unconditionally now. is this issue outdated or is the description just wrong? is it just the same as #2090?

MistakeNot4892 commented 5 months ago

Per Discord, space only generates corners when needed.