search

NebulaSS13 / Nebula

A general purpose SS13/Baystation12 fork.
https://discord.gg/Ddw58yF
GNU Affero General Public License v3.0
48 stars 208 forks source link

Replace a number of hooks with observation decls, remove deprecated hooks #4157

Closed out-of-phaze closed 7 hours ago

out-of-phaze commented 4 days ago

Description of changes

Replaces /hook/submap_join, /hook/player_latejoin, /hook/sell_crate, /hook/terminate_employee, /hook/reassign_employee, /hook/change_account_status, /hook/revoke_payroll, /hook/borgify, and /hook/debrain with corresponding observation decls. Removes /hook/death because it handled on-species death effects which are now handled elsewhere. Removes /hook/clone because we don't have cloning. Makes auxtools debugging not use hooks.

Why and what will this PR improve

Hooks are an old and gross system and I want to deprecate them in favour of observation events. hooks-def.dm was one of the oldest files in our codebase before this.

MistakeNot4892 commented 3 days ago

Changes generally look fine, but honestly I would rather we just blow away all these extraneous events/hooks that have no associated logic.

MistakeNot4892 commented 1 day ago

Per Discord it's unclear what is in current use so happy to merge this as-is and revisit cleaning up unneeded observs later.