NebulaSS13 / Nebula

A general purpose SS13/Baystation12 fork.
https://discord.gg/Ddw58yF
GNU Affero General Public License v3.0
49 stars 221 forks source link

Serpentid Movement Issue #4268

Open tiramisuapimancer opened 1 month ago

tiramisuapimancer commented 1 month ago

Description of issue

Messing with serpentids on a friend's locally hosted server. The second I move over an open space tile I become unable to move by walking, completely frozen up, could not even change the direction I was facing by examine or by attempting movement. Move Down and Move Up commands did not work. I was able to move by climbing over railings and by clicking on ladders, but actually climbing Down a ladder did not work. Other players were able to move and drag my character.

Difference between expected and actual behavior

Should be able to freely move around instead of being locked up, including being able to move downward on open space tiles you are flying/hovering over.

Steps to reproduce

Be serpentid. Walk over an open tile. Attempt to move of your own intention.

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Client Version: 515 Server Revision: 65f73b4969d3389861c23ede7f6b09e022377509 - dev - 2024-07-28 was on a friend's local Current map: Tradeship Ocelot Alpha

Issue bingo

tiramisuapimancer commented 1 month ago

doesn't trigger with adherent flight

tiramisuapimancer commented 1 month ago

image what

MistakeNot4892 commented 11 hours ago

Noting that serpentid just float indefinitely and can move up/down on openspace on stable, no apparent movement issues.

MistakeNot4892 commented 10 hours ago

There is a recursion in Enter() on dev that is causing moving to never be unset.

MistakeNot4892 commented 10 hours ago

Seems to have been the wonky serpentid can_overcome_gravity() block with the releated CanZPass() calls.