MMI and Zat_Zhing (Scav Specific) Show Evidence Of Change_Species Method Failing

EvilDrCoconut commented 1 month ago

Description of issue

When a player has their body changed, their brain spirit (or mind or whatever) is ejected from the body, despite that the body is fully fine. It requires an admin to take the person's ghost and put it back into the body. Looking into the code of zat_zhing, where the change_appearance method is called, following that stack it looks possible that the error may be handle_pre_spawn from species.dm as it only returns (don't know if it did anything before).

Difference between expected and actual behavior

Expected: when brain gets dumped into a MMI or someone gets "zat_zinged" (change_species) that they will have species changed or be put into MMI.

Actual: removes the persons ghost and considers them dead unless an admin puts them back into the body. In the case of MMI, treats it like body has been destroyed (might need to check more on this, I wrote the zat_zhing code and tested it recently and noticed the issued. Others claim to have similar issue with MMI)

Steps to reproduce

Put someone's brain into an mmi (uncertain if this will trigger correctly) Use a zat_zhing stone on a non-yinglet (Scav-Station specific; know this will trigger response)

Specific information for locating

No message, just ejects ghost

Length of time in which bug has been known to occur

Uncertain, only knew about it recently in testing the zat_zhing stone. So within last 2 weeks.

Client version, Server revision & Game ID

Runtime Version 514.1589 Compiler Version 514.1589 Revision 04e095cc8da9a9fa124d63a9a3488b22b876df90

Issue bingo

[ x] Issue could be reproduced at least once
[ x] Issue could be reproduced by different players
[ x] Issue could be reproduced in multiple rounds
[ x] Issue happened in a recent (less than 7 days ago) round
[ x] Couldn't find an existing issue about this

MistakeNot4892 commented 1 month ago

I think this is specifically due to the brain being removed or deleted.

MistakeNot4892 commented 1 month ago

Species issue fixed in #4377. Cannot reproduce MMI issues on current Neb stable, will need more information about the specific issue being encountered.

sirleatherflute commented 1 month ago

Oh, I actually had something like that trying to "reanimate" fbp user. I detached their MMI cause body needed to have everything replaced, and when I plugged it back in, the player was ghosted, but could re-enter, to a "dead" body, at which point I could reconnect their battery and "restart" them.

Also might be entirely different issue, it's been noticed lately, that monkeys go "SSD" after you make them sleep on the surgery table. Their brain is alive, but they remain unconscious.