Converting many grab attackby() blocks into grab_attack().

NebulaSS13 / Nebula

A general purpose SS13/Baystation12 fork.

https://discord.gg/Ddw58yF

GNU Affero General Public License v3.0

49 stars 221 forks source link

Converting many grab attackby() blocks into grab_attack(). #4466

Closed MistakeNot4892 closed 1 week ago

MistakeNot4892 commented 2 weeks ago

Description of changes

Breaks various blocks out of attackby() into grab_attack().

Why and what will this PR improve

Allows grab attack overrides to function properly without wonky proc flow like structure base grab interactions talking precedence over attackby().

Authorship

Myself.

Changelog

Nothing player-facing.

MistakeNot4892 commented 2 weeks ago

Depends on #4462 railing changes.

MistakeNot4892 commented 1 week ago

All appears to be working.

MistakeNot4892 commented 1 week ago

a little worried about the reversed arg order (user then item instead of item then user) causing issues down the line/when migrating legacy code, but it'll probably be fine. ~it's something typemaker will hopefully be able to detect eventually, at least~

Easy enough to tweak it.