assorted icon issues

[ZirconiumWit]

Description of issue

Double barreled shotgun (/obj/item/gun/projectile/shotgun/doublebarrel) + biohazard suit (/obj/item/clothing/suit/bio_suit/scientist ) + ‘the gun’ (/obj/item/gun/projectile) + 'the dart gun' /obj/item/gun/projectile/dartgun + Pirate’s laser cutlass when ACTIVATED (/obj/item/melee/energy/sword/pirate ) all bugged when held or worn – visible when not viewed in inventory, but not visible in inventory icons. Probably more, I don’t quite know what ties all these together besides several are guns

-related – wirecutter handle appears in inventory icon, but wirecutter head does not. Kabobs made in oven have only the metal kabob handle, but no visible food contents.
Teleportation pad (/obj/machinery/merchant_pad) has no on-ground icon, but is visible in a right-click menu.

Similarly, on-character icons are weird for several guns. Dart gun is overwhelmingly large when you hold it

but is invisible when on the ground and has no hand inventory icon

alternatively, the advanced laser gun is FINE in your inventory and in your hand, and shows up properly on your character (An infestation of rats surrounded me for my testing, they're excited by the prospect of this report going out)

but the advanced laser gun appears huge on your character, or like you've dropped it when you loop it into your belt slot.

There's so many oddities that have cropped up fairly recently, I'm completely unable to document them all

Difference between expected and actual behavior

expected: Icons appear Actual: Icons fucky, but only some

Steps to reproduce

play with various pieces of equipment. spot oddities.

Specific information for locating

object names listed in description for precise discussion. I don't necessarily care to copy/paste 'em all down here, sorry.

Length of time in which bug has been known to occur

couple weeks, sorry it's not reported sooner

Client version, Server revision & Game ID

Client Version: 512 Server Revision: 49687b99e2f79a4dd8a2030538ec9e5dff91a902 - dev - 2020-06-09 Game ID: b7z-dHQj Current map: Tradeship Ivenmoth

Issue bingo

• [x] Issue could be reproduced at least once
• [x] Issue could be reproduced by different players
• [x] Issue could be reproduced in multiple rounds
• [x] Issue happened in a recent (less than 7 days ago) round
• [x] Couldn't find an existing issue about this

[MistakeNot4892]

I blame @comma

[comma]

• Double barreled shotgun (/obj/item/gun/projectile/shotgun/doublebarrel) - icon and iconstate weren't set by default, fixing that
• biohazard suit (/obj/item/clothing/suit/bio_suit/scientist ) - seems to be working fine?
• ‘the gun’ (/obj/item/gun/projectile) - not really an obtainale type, made it use pistol icon anyway
• 'the dart gun' /obj/item/gun/projectile/dartgun - missing world icon actually, fixing that
• Pirate’s laser cutlass when ACTIVATED (/obj/item/melee/energy/sword/pirate ) - iconstate was overriden to normal e-sord, fixing that
• advanced laser gun - seems to be working fine in belt slot?
• Dart gun is overwhelmingly large when you hold it - couldn't reproduce
• wirecutter was fixed at some point
• Teleportation pad - visible ingame, maybe got fixed at some point
• kabob - both normal and tofu versions have meat on the icon currently