search

NebulousLabs / Sia-UI

A Graphical Frontend for Sia - https://sia.tech
MIT License
389 stars 109 forks source link

There is no warning when downloading a file to a folder containing a same-named file. #639

Open Zerrien opened 7 years ago

Zerrien commented 7 years ago

Sia UI version: v1.2.2 Sia version: 1.2.2

OS version: Windows 10 Version 10.0.14393 Build 14393

Steps to reproduce: 1) Upload file to the network. 2) Make a change to your locally stored file, (which will be noticeable should you overwrite it.) 3) Download the file from the network to the folder with your changed version. 4) Notice there is no warning dialog about overwriting an existing file. (Also notice none of the individual files are displayed in the file explorer for a given folder, but that's probably a different issue.) 5) Open the changed, locally stored file. 6) Observe the contents.

Actual Result: The file was overwritten with no warning.

Expected Result: I expected a warning dialog to warn me that my locally stored file may be overwritten.

lukechampine commented 7 years ago

Thank you for the detailed report. @johnathanhowell, I think this may be because we use the same filepicker for both single-file downloads and folder downloads. In the former case, we should be using the single-file filepicker dialog.