search

NebulousLabs / Sia

Blockchain-based marketplace for file storage. Project has moved to GitLab: https://gitlab.com/NebulousLabs/Sia
https://sia.tech
MIT License
2.71k stars 440 forks source link

Wallet balance does not match transaction sum #2816

Open mtlynch opened 6 years ago

mtlynch commented 6 years ago

BUG REPORT

I have a host that I've been running for almost two years. At some point, I swept an additional wallet seed into it. I'm trying to understand my transaction history, but the sum of my transactions (from wallet transactions) don't match the reported balance (from wallet balance).

To debug, I loaded the seeds separately on different VMs. Wallet 1 has my host's primary seed. Wallet 2 uses my host's auxiliary seed:

Wallet Reported Balance Reported Transaction Sum
1 16.72 KS -11,729.14 SC
2 4.986 KS 4,985.59 SC
(1 primary, 2 auxiliary) 21.71 KS -6,743.55 SC

The problem seems to be in seed 1 (the primary seed). It reports a balance of 16.72 KS but its transactions add up to -11.73 KS.

Environment

hackneyb commented 6 years ago

Could be pure coincidence but 16.72KS less 11729.14SC is 4.990KS. That seems to suggest some consistency, and if you assume that 16.72KS could be 16.716KS rounded up, you get the exact 4.986 KS value. So the bug would be how transactions are attributed per wallet seed and how they accumulate to display the balance. Or, they don't accumulate to display the balance because some transactions are missing.

And .. I have just done the same and I can reproduce this without any additional swept seeds. Single wallet, never changed other than generating a few more addresses.

Transaction sum: 1457. Wallet balance: 1687

If this trend continues, at some point my transaction sum will go below 0 and my wallet balance will still be positive, since today it is higher by 230SC. I could interpret this as: my host made 230SC since running, and yours made at least 11KS.

You could be seeing the exact same phenomenon. I am told that this happens when SC rewarded to the host does not get reflected in wallet transactions, but it must be that it is reflected in total balance. In other words, transaction ledger is incomplete as a means of reconstructing wallet balance.

MSevey commented 6 years ago

@mtlynch when #3087 gets merged that should address some more of the spend reporting discrepancies we have been seeing. Once it is merged I'd ask if you could see if you can recreate the bug or if it helped at all.