1.3.3 RC2: "renter allowance cancel" destroys all renter contracts and data

[mtlynch]

BUG REPORT

How to reproduce it (as minimally and precisely as possible)

1. Create renter contracts with siac renter setallowance
2. Disable contract renewal with siac renter allowance cancel

Expected Behavior

Sia maintains existing contracts, but does not automatically renew them.

Actual Behavior

Sia destroys all contracts and loses all data.

Environment:

• Sia version: Sia 1.3.3 RC2
• OS: Ubuntu 16 (Docker container)

Logs

• Before allowance cancel
• After allowance cancel

[tbenz9]

@lukechampine can you confirm that this is the expected behavior?

[DavidVorick]

This is intended behavior, though there was some internal disagreement when it was implemented over whether it was the right way to design the api call.

I'm in favor of changing the call so that instead of destroying all of the contracts, it just collapses the allowance and stops renewing.

[lukechampine]

that seems much more reasonable to me. Shouldn't be too difficult to implement.