search

NebulousLabs / Sia

Blockchain-based marketplace for file storage. Project has moved to GitLab: https://gitlab.com/NebulousLabs/Sia
https://sia.tech
MIT License
2.71k stars 440 forks source link

i3009 renter settings #3015

Closed MSevey closed 6 years ago

MSevey commented 6 years ago

resolves #3009 upload and download speeds were being reset to defaults as they were not being returned when Settings() was called on the renter

tbenz9 commented 6 years ago

Hey @MSevey, you may already know this but GitHub uses keywords to manage linked issues. You might consider saying something like resolves #3009 instead of address issue #3009 so that the issue gets closed automatically when this PR gets merged in. GitHub keywords work in titles and descriptions so it's best practice to title issues with resolves #3009 renter settings instead of i3009 renter settings.

Of course, you need to be careful if you don't want the PR to close the issue, in which case addresses issue #3009 would be perfect since addresses is not a GitHub keyword.

Check out the link below for a full list of keywords: https://help.github.com/articles/closing-issues-using-keywords/

Keep up the good work, the community is loving the PRs you're working on!

MSevey commented 6 years ago

@tbenz9 thanks for the info, I'll check out that link!

MSevey commented 6 years ago

Build fail due to pending PR on NebulousLabs/ratelimit