search

NebulousLabs / Sia

Blockchain-based marketplace for file storage. Project has moved to GitLab: https://gitlab.com/NebulousLabs/Sia
https://sia.tech
MIT License
2.71k stars 440 forks source link

Cancel allowance shouldn't delete contracts #3051

Closed ChrisSchinnerl closed 6 years ago

ChrisSchinnerl commented 6 years ago

Fixes #3013

tbenz9 commented 6 years ago

Wow, that was fast. Seems a little silly but if this changes the behavior to keep existing contracts active you should probably remove the warning I just put in with #3049.

DavidVorick commented 6 years ago

We got lucky with the implementation here. If we had made a few different design choices earlier, this would have been more difficult to implement.

As it were, we do try to program such that changing things later is easy, but in this case I think we really did just get lucky.

DavidVorick commented 6 years ago

Other than the user-facing message, this looks good, including the test.